Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-remark-images): enable relative images in jsx content #14314

Merged
merged 1 commit into from
May 26, 2019

Conversation

ChristopherBiscardi
Copy link
Contributor

Enables image processing for MDX with JSX tags for content such as the example
below.

<figure>
  <img alt="The modularization of the CMS" height="400" src="./modular-cms-architecture.png" />
  <figcaption>
   The modularization of the CMS
  </figcaption>
</figure>

Issue can be reproduced without this change by looking at / (index.mdx) in this repro repo: https://github.com/ChristopherBiscardi/gatsby-mdx-remark-images-jsx-tags-repro. Note that the markdown syntax works and the JSX does not before this change, and after this change the JSX syntax works as well.

Enables image processing for MDX with JSX tags for content such as the example
below.

```html
<figure>
  <img alt="The modularization of the CMS" height="400" src="./modular-cms-architecture.png" />
  <figcaption>
   The modularization of the CMS
  </figcaption>
</figure>
```
@pieh pieh changed the title Enable relative images in jsx content feat(gatsby-remark-images): enable relative images in jsx content May 26, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, thanks!

@pieh pieh merged commit 1ccc3c2 into gatsbyjs:master May 26, 2019
@pieh
Copy link
Contributor

pieh commented May 26, 2019

Published [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants