feat(gatsby-remark-images): Add support for native lazy loading #16448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabefromutah
commented
Aug 7, 2019
gabefromutah
force-pushed
the
topics/gatsby-remark-images-lazy-loading
branch
from
cc85dee
to
7115433
Compare
|
Nice! Perhaps we could default to |
added 2 commits
August 7, 2019 14:57
muescha
reviewed
Aug 8, 2019
sidharthachatterjee
previously approved these changes
Aug 11, 2019
There was a problem hiding this comment.
Looks good! I went ahead and added a small warning in case the user passes in an invalid value
Thank you so much @gabefromutah 👍
…ark-images-lazy-loading
sidharthachatterjee
changed the title
sidharthachatterjee
added
the
bot: merge on green
…ark-images-lazy-loading
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-imagehas already implemented this feature a while back. Now that Chrome 76 is available, let us also updategatsby-remark-imagesto support lazy-loading. This is one of my first PRs and I'm not 100% certain I've covered all the areas to make this happen.Fixes #15716