Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-images): Allow alt to be returned as caption #16518

Merged
merged 3 commits into from
Aug 11, 2019
Merged

fix(gatsby-remark-images): Allow alt to be returned as caption #16518

merged 3 commits into from
Aug 11, 2019

Conversation

pedrolamas
Copy link
Contributor

@pedrolamas pedrolamas commented Aug 10, 2019

This ensures that only manually set alt attribute will be available to be returned as a figcaption element value (but still ignores the generated defaultAlt)

Related Issues

Fixes #16517

This ensures that only manually set `alt` attribute will be available to be returned as a `figcaption` element value (but still ignores the generated `defaultAlt`)
@pedrolamas pedrolamas requested a review from a team as a code owner August 10, 2019 17:41
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix! Thank you for this @pedrolamas 👍

@sidharthachatterjee sidharthachatterjee changed the title Fixes #16517 - allow alt attribute to be returned as caption fix(gatsby-remark-images): Allow alt to be returned as caption Aug 11, 2019
@sidharthachatterjee sidharthachatterjee merged commit f09e82f into gatsbyjs:master Aug 11, 2019
@pedrolamas pedrolamas deleted the pedrolamas/fix-remark-images-alt branch August 11, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image captions ignore alt value if it matches the filename
2 participants