feat(gatsby-remark-images): Add flag to suppress css background-image to prevent FOUB #17154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimbaudi
requested review from
ajschmidt8 and
chasemccoy
and removed request for
ajschmidt8,
chasemccoy and
gabefromutah
lannonbr
changed the title
lannonbr
added
the
topic: media
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
…y-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
wardpeet
reviewed
Sep 9, 2019
Co-Authored-By: Ward Peeters <[email protected]>
|
Thanks for the code review. I've made the necessary changes. |
|
ok sweet, thanks. Doing a quick test and I'll merge right after! Thank you for doing this and for your patience. |
wardpeet
approved these changes
Sep 10, 2019
wardpeet
approved these changes
Sep 10, 2019
kimbaudi
deleted the
topics/gatsby-remark-images-add-flag-to-disable-bg-img-on-images-w-transparency
branch
|
@wardpeet - Although this PR got merged into master and gatsby-remark-images doc shows the new |
|
I just confirmed that this PR got merged into master 😄 |
LOLdevelopr
pushed a commit
to LOLdevelopr/gatsby-1
that referenced
this pull request
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes to gatsby-plugin-sharp and gatsby-remark-images in order to address issue #16516.
I created a new option for
gatsby-remark-imagesplugin calleddisableBgImageOnAlphawhich is disabled by default. WhendisableBgImageOnAlphais enabled (i.e., set totrue), it will check the image file for opacity/transparency. If the image contains transparency, then thebackground-imagecss property is disabled on<span class="gatsby-resp-image-background-image"></span>, which will prevent the "flash of ugly blur-up" (FOUB).The reason why I made changes to
gatsby-plugin-sharpis to expose stats, which is how I determine whether the image contains transparency.Related Issues
Fixes #16516