-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async-requires.js relative includes broken since #18973 #19931
Comments
Having the same problem |
Also with gatsby-plugin-i18next |
Can this please be triaged. It seems to have been missed and is breaking existing sites that were working fine. |
@Atr0p got the same issue with
@wardpeet @pieh @freiksenet could you kindly take a look? |
This starter could be used for reproduction: https://github.com/ikhudo/gatsby-i18n-plugin/tree/master/starters/gatsby-starter-i18next |
Description
After the changes made in #18973, specifically these lines, my website no longer builds successfully.
This is because async-requires.js previously imported components like this, which worked great:
After the recent change, components are now imported like this:
It works if I change it to import files using ./ at the start:
The templates are dynamically generated so need to be in the cache folder so that they get cleaned up during
gatsby clean
.Steps to reproduce
createPage({component: "C:\\git\\website\\.cache\\page-templates\\example.jsx"})
Expected result
Successful build.
Actual result
Environment
System:
OS: Windows 7
CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Binaries:
Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.10.0 - C:\Program Files\nodejs\npm.CMD
Languages:
Python: 2.7.15
@wardpeet
The text was updated successfully, but these errors were encountered: