New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest plugin does not respect the path prefix conf #2078

Closed

lilac opened this issue Sep 11, 2017 · 1 comment · Fixed by #3170

Contributor

lilac commented Sep 11, 2017

It is hard coded as "/manifest.json" as in

gatsby/packages/gatsby-plugin-manifest/src/gatsby-ssr.js

Line 8 in 78aaeab

href="/manifest.json"

This causes manifest 404 when deployed in hosts like Github.

Contributor

KyleAMathews commented Sep 11, 2017

Hmm you're right. Thanks for reporting this! Would you like to put together a PR with a fix?

canastro mentioned this issue

Add pathPrefix support to manifest plugin #3170

Merged

KyleAMathews closed this as completed in #3170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment