StrictMode Error: Please update the following components: ScrollContext

[master12]

I copied this comment from #10179 since it was not really related to that particular error. However this does occur in StrictMode and it would be nice to get this resolved.

It was also posted in this issue #13676 but that has been closed without a resolution.

I'm getting the following error with StrictMode:

Warning: Legacy context API has been detected within a strict-mode tree: 
    in StrictMode (created by App)
    in App
    in _default

Please update the following components: ScrollContext

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings

It seems that ScrollContext is still using legacy context:

gatsby/packages/gatsby-react-router-scroll/src/ScrollBehaviorContext.js

Lines 14 to 16 in bddfcbc

	const childContextTypes = {
	scrollBehavior: PropTypes.object.isRequired,
	}

Related:

Reminder: mere presence of legacy context API in the tree puts everything below it onto a slower code path. It is worth migrating away from.
— https://twitter.com/dan_abramov/status/1097866569701621763

[sidharthachatterjee]

Happy to accept a PR fixing this!

[akshitkrnagpal]

@sidharthachatterjee
Hey, I am just getting started with Gatsby.
Can I work on this? 😄

[skarunakar]

@akshitkrnagpal Are you working on this ??

[herecydev]

I've added a PR that should resolve this

[herecydev]

It's worth noting this plugin also calls findDOMNode which needs replacing to be "strict mode compliant"

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜