Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Run SSR in Develop ☔ #25729

Closed
blainekasten opened this issue Jul 13, 2020 · 13 comments
Closed

[Umbrella] Run SSR in Develop ☔ #25729

blainekasten opened this issue Jul 13, 2020 · 13 comments
Assignees
Labels
type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Comments

@blainekasten
Copy link
Contributor

Summary

Gatsby currently does not run SSR in develop mode. This has caused some users headaches when they deploy gatsby apps to find that there are production-only issues due to SSR.

The solution is to convert gatsby develop into running true SSR.

Motivation

To make Gatsby easier to use, prevent hard to debug errors, and have a more consistent developer experience.

@teclone
Copy link

teclone commented Jul 15, 2020

@blainekasten , I am ready to start looking into this from tomorrow. I will need to sync with you to get all the necessary understanding of what needs to be done, are you ready and willing to discuss this with me?

@blainekasten
Copy link
Contributor Author

@teclone Yes! Send me an email at [email protected] and we'll set up a time to hop on a video call to discuss!

@teclone
Copy link

teclone commented Jul 15, 2020

@teclone Yes! Send me an email at [email protected] and we'll set up a time to hop on a video call to discuss!

ok, done, thanks

@eyalroth
Copy link
Contributor

Related: #10706

@vladar
Copy link
Contributor

vladar commented Aug 3, 2020

What would be the outcome of this umbrella issue? We have a PR: #24872 that does something similar (runs renderToString in develop).

But it fixes only a subclass of hydration issues (won't handle things like typeof windows checks, etc.

@blainekasten
Copy link
Contributor Author

@teclone thanks for reaching out! This feature is actually now a priority of the core team for the next few sprints so we'll be able to complete it!

@blainekasten
Copy link
Contributor Author

@vladar I believe it is to create a proper SSR implementation and not the partial solution

@teclone
Copy link

teclone commented Aug 13, 2020

@teclone thanks for reaching out! This feature is actually now a priority of the core team for the next few sprints so we'll be able to complete it!

@blainekasten , Thanks a lot, I am following up with the progress. Kudos to you all

@lucashfreitas
Copy link

This would be neat! I am constantly running into small issues due SSR and have to run gatsby build/serve every time. Would be really useful to use that feature.

Would love to help as well 👍

@jakezien
Copy link

jakezien commented Sep 25, 2020

+1 on this — my styled components break in production but look fine on dev.

@KyleAMathews
Copy link
Contributor

Hey everyone! We've shipped an initial version of SSR in develop in 2.27.0 — upgrade & try it out!

GATSBY_EXPERIMENTAL_FAST_DEV=true gatsby develop

Read more about it + some other initiatives we're working on to speedup/improve the dev server https://github.com/gatsbyjs/gatsby/blob/master/docs/reference/release-notes/v2.27/index.md

@KyleAMathews
Copy link
Contributor

Also if you find bugs or oddities w/ dev ssr (or if you just want to comment on how awesome it is ;-)) — let us know over at #28138

@LekoArts
Copy link
Contributor

I'll close this in favor of the same discussions, no point in having two duplicate things open: #28138

Please head on over there and give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

10 participants