fix(gatsby-remark-images): Use pathPrefix also with WebP files #26472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
frncesc
changed the title
wardpeet
reviewed
Aug 18, 2020
wardpeet
added
topic: remark/mdx
Trailing comma in line 221 of packages/gatsby-remark-images/src/index.js is causing a lint error (related to a prettier rule) in CircleCI
|
I added a commit deleting the comma at the end of the parameter list passed to |
wardpeet
removed
the
status: awaiting author response
wardpeet
approved these changes
Aug 24, 2020
|
Successfully published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #26471, pictures are not shown on Gatsby sites with
pathPrefixwhengatsby-remark-imageshaswithWebpenabled.This PR just adds the parameter
{ pathPrefix }to the args passed to fluid when buildingwebpFluidResult, as is done when buildingfluidResultwith the mainoptionsobject (built in line 38)Documentation
Despite not beign oficially documented as a valid param, gatsby-plugin-sharp, makes use of the
pathPrefixparam, as can be seen onfluidand other functions.Related Issues
Fixes #26471