Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-manifest): re-use domain connection #26946

Merged
merged 3 commits into from
Sep 27, 2020

Conversation

wardpeet
Copy link
Contributor

Description

Manifest file opens up a new connection to download it because it lacks crossorigin by default.

image

This changes to

image

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 18, 2020
@LekoArts LekoArts added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 21, 2020
@moonmeister
Copy link
Contributor

Looks good to me, you may need to update some snapshots though.

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 25, 2020
@gatsbybot gatsbybot merged commit 6d0d2ef into gatsbyjs:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants