Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-manifest): create directories recursively #27793

Merged
merged 3 commits into from
Nov 2, 2020

Conversation

KyleAMathews
Copy link
Contributor

It's possible to have directories nested multiple layers deep or potentially that public isn't defined.

It's possible to have directories nested multiple layers deep or potentially that `public` isn't defined.
@KyleAMathews KyleAMathews requested a review from a team as a code owner November 2, 2020 19:04
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 2, 2020
thinkybeast
thinkybeast previously approved these changes Nov 2, 2020
Copy link
Contributor

@thinkybeast thinkybeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleAMathews KyleAMathews added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 2, 2020
vladar
vladar previously approved these changes Nov 2, 2020
thinkybeast
thinkybeast previously approved these changes Nov 2, 2020
@KyleAMathews KyleAMathews dismissed stale reviews from thinkybeast and vladar via 794bf4a November 2, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants