chore(gatsby-plugin-sharp): Upgrade sharp #28119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
commented
Nov 17, 2020
| @@ -5,7 +5,7 @@ Object { | |||
| "aspectRatio": 1, | |||
| "height": 20, | |||
| "originalName": "test.png", | |||
| "src": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAUCAIAAAAC64paAAAACXBIWXMAAAsSAAALEgHS3X78AAABKklEQVQ4y8WUy07DMBBFrwMpr4aybjepUeqIFd/CAgmJsuIHgWXVL+Gx4C3xCdQJnpm0UDJNAQnVuouMM8dzY4+DcoA/C/8Fe9bv4ABMMpQOZc5yFPqfwEUQY499jHoY9/BsKQyTRTNMyzu8WAwTbBnI2DY438XbPr0qFsFCvlrkMTERYFgRL3HYUvh5OMdpQqkbBtPC9NDiINQPCZM6LGVvUzIpwNch4V5EGxHS/DeYtjfHZbcyXB8yGfaPimcafLEMHqmw2L5OsWkUUuY6Ee5V28WUP25TXjwPS3iWUFnfcFQPFna98rlmSGL4IOZucQvgT76Po53qeOTYTtp4qpFKe/qM29PhJsVVl3SXsluntLfS7rPvn10MP1Aau+lKBuA9I/kV/AyW6gNTIWTuA/r8lQAAAABJRU5ErkJggg==", | |||
| "src": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAUCAIAAAAC64paAAAACXBIWXMAAAsTAAALEwEAmpwYAAABOklEQVQ4y2P4r8ZANmKgvuZ/agy/VaHojyopmv+CNf/XQCCoCEHNf1VBqv+oM5yVY1giwbBakuG2AkjknzoW/eh2AtWdkWMwZ2cAAkYQwcDCwBDOw/BCGWwELs1wnfxMUJ1MMBIIjNkY3gH1o9qPCCGIfisOkFI2iKUMUFPYwdxcfrCPVDE0/wFbe0QGpIiJAR1AjJJlYXiPajlMMzicpouBFDEz4AQX5KCBj0XzXHECmi/JY9MMCa1zciAXMmLogXhEiYXhqwoigFBCGyLkzQVSBwwhuM+ZYeHXKIQjwKCWqzM8UGRQYUUJNgjDl4vhlxqKtdgSiTrDYyWGGF4GXphucWaGOiGG76rokYw9eQJTItB5L5QYTsqBEulHoD81sSdv7FkK4gRoxlAnOmMgewGSJf/StTAgEgEA1PJk9+Vu8VgAAAAASUVORK5CYII=", | |||
There was a problem hiding this comment.
I've confirmed that these images are visually identical
pvdz
approved these changes
Nov 17, 2020
vladar
approved these changes
Nov 17, 2020
pvdz
added
topic: sharp
and removed
status: triage needed
ascorbic
changed the title
ascorbic
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade sharp to ^0.26.3. We can do this now that it no longer requires newer node versions. The main benefit for us now is that it adds support for dominant colors, which we use in the new image transformer if it's available