Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-manifest): Add support for share_target #28457

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 3, 2020

Adds support to plugin options for share_target, which is a draft supported by Chrome. I have only included the keys in the draft spec, but have allowed unknown keys because Google already seems to be adding more.

Fixes #28455

@ascorbic ascorbic added the topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins label Dec 3, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 3, 2020
@ascorbic ascorbic added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 3, 2020
@ascorbic ascorbic merged commit 1fe3f9a into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/manifest-share-target- branch December 3, 2020 17:07
@moonmeister
Copy link
Contributor

Just going to leave a note here for future reference that this was the "Unofficial Draft 12 June 2020" version of the draft spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: there are unknown plugin options for "gatsby-plugin-manifest": share_target
3 participants