Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update sharp to 0.28.0 #30541

Merged
merged 2 commits into from
Apr 1, 2021
Merged

chore: Update sharp to 0.28.0 #30541

merged 2 commits into from
Apr 1, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 29, 2021

Upgrades sharp to 0.28.0. This has smaller install size, and now uses prebuilt libvips binaries for M1 Macs.

This version also includes built-in image optimisation, that could mean we can drop the imageoptim stage from builds, which we'll evaluate separately.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 29, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 29, 2021
@ascorbic ascorbic marked this pull request as ready for review March 31, 2021 14:43
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds cool! 🚢

@rossng
Copy link

rossng commented Mar 31, 2021

Great! I was just about to open an issue when I found this PR (since gatsby-plugin-sharp wouldn't install on my M1 Macbook).

@ascorbic ascorbic merged commit b0fcb57 into master Apr 1, 2021
@ascorbic ascorbic deleted the chore/upgrade-sharp branch April 1, 2021 07:57
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* chore: Update sharp to 0.28.0

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants