fix(gatsby-plugin-manifest): consider path prefix when getting localized manifest #34174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: plugins-PWA
|
Cool! You'll need to run the |
marvinjude
changed the title
marvinjude
force-pushed
the
fix/manifest-local
branch
from
b4c866a
to
6b2098d
Compare
wardpeet
reviewed
Dec 3, 2021
packages/gatsby-plugin-manifest/src/__tests__/gatsby-browser.js
Outdated
Show resolved
Hide resolved
wardpeet
added
the
bot: merge on green
wardpeet
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apps built with
--pathPrefixneed to considerpathPrefixwhen getting localized manifest from plugin config. This PR address thatDocumentation
https://www.gatsbyjs.com/plugins/gatsby-plugin-manifest/#localization-configuration
Related Issues
fixes #33965