Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The repository archived babel-plugin-lodash is using the deprecated isModuleDeclaration. #38786

Closed
2 tasks done
dearlsh94 opened this issue Dec 28, 2023 · 0 comments · Fixed by #38797
Closed
2 tasks done
Labels
topic: webpack/babel Webpack or babel type: bug An issue or pull request relating to a bug in Gatsby

Comments

@dearlsh94
Copy link

Preliminary Checks

Description

Hello,

I'm relatively new to contributing to open-source projects and raising issues, but I've noticed an important aspect regarding the babel-plugin-lodash used in Gatsby. It currently utilizes isModuleDeclaration, which has been deprecated. Additionally, it's worth noting that as of September 17, 2023, babel-plugin-lodash has been archived and is no longer actively maintained or updated.

Issue:
The isModuleDeclaration within babel-plugin-lodash has been deprecated. And babel-plugin-lodash will be archived as of September 23, 2023 and will not be modified.

Impact:
This can be addressed to ensure compliance with the latest BABEL standards.

Thank you for considering this issue. Looking forward to any updates or thoughts on this matter.


babel-plugin-lodash : https://github.com/lodash/babel-plugin-lodash
Babel ModuleDeclaration : https://babeljs.io/docs/babel-types#moduledeclaration
Babel ImportOrExportDeclaration : https://babeljs.io/docs/babel-types#importorexportdeclaration

Reproduction Link

Sorry about that. I'm not sure what to do with this.

Steps to Reproduce

  1. gatsby build
  2. check terminal
warn `isModuleDeclaration` has been deprecated, please migrate to `isImportOrExportDeclaration`
    at isModuleDeclaration

Expected Result

no warning

Actual Result

A warning has occurred

The first build the project, I could see the warning but it didn't happen on rebuilds.

Environment

System:
    OS: macOS 12.3
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.15.0 - /var/folders/dw/qdrsnx7171xcthmt7jvrl_dh0000gn/T/yarn--1703749151838-0.15695349044010531/node
    Yarn: 1.22.19 - /var/folders/dw/qdrsnx7171xcthmt7jvrl_dh0000gn/T/yarn--1703749151838-0.15695349044010531/yarn
    npm: 9.5.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 15.4
  npmPackages:
    gatsby: ^5.12.11 => 5.12.11
    gatsby-omni-font-loader: ^2.0.2 => 2.0.2
    gatsby-plugin-alias-imports: ^1.0.5 => 1.0.5
    gatsby-plugin-canonical-urls: ^5.12.0 => 5.12.0
    gatsby-plugin-google-adsense: ^1.1.3 => 1.1.3
    gatsby-plugin-google-gtag: ^5.12.3 => 5.12.3
    gatsby-plugin-image: ^3.12.3 => 3.12.3
    gatsby-plugin-manifest: ^5.12.3 => 5.12.3
    gatsby-plugin-netlify: ^5.1.1 => 5.1.1
    gatsby-plugin-sass: ^6.12.3 => 6.12.3
    gatsby-plugin-sharp: ^5.12.3 => 5.12.3
    gatsby-plugin-sitemap: ^6.12.3 => 6.12.3
    gatsby-source-filesystem: ^5.12.1 => 5.12.1
    gatsby-source-notion-feely: ^2.0.0 => 2.0.0

Config Flags

DEV_SSR: true,
FAST_DEV: true,

@dearlsh94 dearlsh94 added the type: bug An issue or pull request relating to a bug in Gatsby label Dec 28, 2023
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 28, 2023
@pieh pieh added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: webpack/babel Webpack or babel type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
2 participants