Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept clicks @ top level so markdown links and other links not using React Router don't force reload #93

Closed
KyleAMathews opened this issue Nov 26, 2015 · 4 comments

Comments

@KyleAMathews
Copy link
Contributor

This module would make this a very easy PR https://github.com/substack/catch-links

@thangngoc89
Copy link
Contributor

Wow. Never heard of this. Statinamic has this issue too MoOx/phenomic#67

@fson
Copy link
Contributor

fson commented Feb 18, 2016

If implemented, maybe this should be configurable? I'm currently (ab)using this to force a page reload for some pages by using <a> instead of <Link>.

@KyleAMathews
Copy link
Contributor Author

@fson noted :D that's a pretty valid reason.

So a thought. With #100, reloading a Gatsby site should be near instantaneous making page reloads this link catcher is intended to catch matter a lot less. I vote we wait and see how Service Workers change the experience.

Thoughts?

@KyleAMathews
Copy link
Contributor Author

Gonna close this because there's valid reasons for not intercepting clicks, service workers will solve reload latency problem, and it's easy enough to add this to individual site projects if someone wants it (and could be abstracted into an NPM module too which would be cool).

ChristopherBiscardi added a commit to ChristopherBiscardi/gatsby that referenced this issue Jun 9, 2019
ChristopherBiscardi added a commit to ChristopherBiscardi/gatsby that referenced this issue Jun 27, 2019
johno pushed a commit to johno/gatsby that referenced this issue Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants