Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing argument for providing a custom locale when querying a date #2652

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

sprmn
Copy link
Contributor

@sprmn sprmn commented Oct 27, 2017

This is a fix for a piece of code that was missing in #2382. It enables the use of a locale argument of type GraphQLString in date queries, as suggested in #2382 (comment).

Now you can format the date in a query to another locale like this:

date(formatString: "DD MMMM YYYY", locale: "de")

This will result in a date value of 27 octobre 2017.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 333406c

https://deploy-preview-2652--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Oct 27, 2017

Deploy preview ready!

Built with commit e600663

https://deploy-preview-2652--gatsbygram.netlify.com

@KyleAMathews KyleAMathews merged commit c8cdd00 into gatsbyjs:master Oct 27, 2017
@KyleAMathews
Copy link
Contributor

Thanks!

@jlengstorf
Copy link
Contributor

Hiya @sprmn! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

@stradaroca
Copy link

Thanks for the solution 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants