Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gatsby-transformer-remark to npm install in gatsby-remark-prismjs README #2673

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

prichey
Copy link
Contributor

@prichey prichey commented Oct 29, 2017

This may be totally intuitive to some, but if you add gatsby-remark-prismjs as shown above without having added gatsby-transformer-remark, you get a build failure:

prichey@BE7700 ~/g/prichey-gatsby (master)> yarn deploy
yarn run v1.2.1
$ gatsby build --prefix-paths && gh-pages -d public
success delete html files from previous builds — 0.046 s
success open and validate gatsby-config.js — 0.007 s
error Unable to find plugin "gatsby-transformer-remark"


  Error: Unable to find plugin "gatsby-transformer-remark"

  - load-plugins.js:96 resolvePlugin
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:96:11

  - load-plugins.js:147 processPlugin
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:147:27

  - load-plugins.js:168
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:168:28

  - Array.forEach

  - load-plugins.js:167 _callee$
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:167:28

  - index.js:122 _callee$
    [prichey-gatsby]/[gatsby]/dist/bootstrap/index.js:122:20


error Command failed with exit code 1.

Small change, but it would save beginners from running into the same error I just hit.

…ismjs` README

This may be totally intuitive to some, but if you add `gatsby-remark-prismjs` as shown above without having added `gatsby-transformer-remark`, you get a build failure:

```
prichey@BE7700 ~/g/prichey-gatsby (master)> yarn deploy
yarn run v1.2.1
$ gatsby build --prefix-paths && gh-pages -d public
success delete html files from previous builds — 0.046 s
success open and validate gatsby-config.js — 0.007 s
error Unable to find plugin "gatsby-transformer-remark"


  Error: Unable to find plugin "gatsby-transformer-remark"

  - load-plugins.js:96 resolvePlugin
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:96:11

  - load-plugins.js:147 processPlugin
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:147:27

  - load-plugins.js:168
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:168:28

  - Array.forEach

  - load-plugins.js:167 _callee$
    [prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:167:28

  - index.js:122 _callee$
    [prichey-gatsby]/[gatsby]/dist/bootstrap/index.js:122:20


error Command failed with exit code 1.
```

Small change, but it would save beginners from running into the same error I just hit.
@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit da32669

https://deploy-preview-2673--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

👍 makes sense!

@KyleAMathews KyleAMathews merged commit 0eefe49 into gatsbyjs:master Oct 30, 2017
@KyleAMathews
Copy link
Contributor

Do you think you could make the same change to the other gatsby-remark-* READMEs?

@prichey
Copy link
Contributor Author

prichey commented Oct 30, 2017 via email

@jlengstorf
Copy link
Contributor

Hiya @prichey! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants