-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQLParser errors to verbose output #2873
Add GraphQLParser errors to verbose output #2873
Conversation
Deploy preview ready! Built with commit 143a815 |
Deploy preview ready! Built with commit 143a815 |
hey there, thanks for the PR. I don't think we need to guard against this for verbose or specific parser errors. It's really a bug that the error details are getting swallowed here. Ideally waht should happen is that if the specialized gql error parsing doesn't turn up anything (as in your case) the default reporter behavior should be used, e.g. |
Yeah, I really dislike "verbose" modes generally speaking. @daniel-simpson could you try changing the PR to do as @jquense suggests? |
Was having issues with a malformed graphql query due to the differences between allContentfulX and contentfulX mappings. Very difficult to track down until I added the following GraphQLParser exception. I've scoped this to only show if verbose output is turned on to ensure newbies have some reference while using graphql, without getting in anyone else's way.
c0a5c9e
to
63a6a45
Compare
No problem. I've just updated the PR to display the original error if the formatted graphql error is empty. Very new to the project so please let me know if you prefer different syntax to the one I've used. |
Thanks! |
thanks ! this improve developer experience a lot :) |
thanks 👍 |
Hiya @daniel-simpson! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Was having issues with a malformed graphql query due to the differences between allContentfulX and contentfulX mappings. Very difficult to track down until I added the following GraphQLParser exception. I've scoped this to only show if verbose output is turned on to ensure newbies have some reference while using graphql, without getting in anyone else's way.