Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update 21yunbox guide #28848

Merged
merged 8 commits into from
May 6, 2021
Merged

Conversation

tobyglei
Copy link
Contributor

@tobyglei tobyglei commented Jan 5, 2021

I have noticed the docs are in the reorganizing state. This PR is intended to fix the missing and/or broken links for this page: https://www.gatsbyjs.com/docs/how-to/previews-deploys-hosting/

I have also updated the glossary to include 21YunBox.

FYI, The doc for 21YunBox deployment was merged to main doc last year from this PR: #24429.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 5, 2021
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 5, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Jan 5, 2021

It seems like you didn't move the guide but created a duplicate?

@tobyglei
Copy link
Contributor Author

tobyglei commented Jan 5, 2021

It seems like you didn't move the guide but created a duplicate?

Oh, I forgot to delete it.

Just made the changes and committed again.

@@ -9,7 +9,7 @@ Learn what _build_ means and how to set up a build process for your Gatsby proje

_Build_ refers to the process of compiling your site. During a build, or at _build time_, your project gets transformed from component files to optimized HTML, CSS, and JavaScript files that you can [deploy](/docs/glossary#deploy) to your hosting provider.

There are a few ways to create a build. You can build your site locally on your computer using the [Gatsby CLI](/docs/reference/gatsby-cli/#build), and then deploy changes to your [host](/docs/glossary#hosting). If you use [Gatsby Cloud](https://www.gatsbyjs.com/), you can take advantage of [Gatsby Builds](/blog/2020-01-27-announcing-gatsby-builds-and-reports/), a feature available with every Gatsby Cloud account. You can also use a [continuous deployment](/docs/glossary/continuous-deployment/) service such as [AWS Amplify](/docs/how-to/previews-deploys-hosting/deploying-to-aws-amplify/) or [Netlify](/docs/how-to/previews-deploys-hosting/deploying-to-netlify/).
There are a few ways to create a build. You can build your site locally on your computer using the [Gatsby CLI](/docs/reference/gatsby-cli/#build), and then deploy changes to your [host](/docs/glossary#hosting). If you use [Gatsby Cloud](https://www.gatsbyjs.com/), you can take advantage of [Gatsby Builds](/blog/2020-01-27-announcing-gatsby-builds-and-reports/), a feature available with every Gatsby Cloud account. You can also use a [continuous deployment](/docs/glossary/continuous-deployment/) service such as [AWS Amplify](/docs/how-to/previews-deploys-hosting/deploying-to-aws-amplify/), [Netlify](/docs/how-to/previews-deploys-hosting/deploying-to-netlify/), [21YunBox](/docs/how-to/previews-deploys-hosting/deploying-to-21yunbox/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert that change, it's out of scope of this PR and the paragraph is purposefully only listing those two options. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@tobyglei
Copy link
Contributor Author

@LekoArts Hi Lennart, just a quick follow up. Is there anything I need to do to get this PR merged?

@LekoArts
Copy link
Contributor

@meganesu will know :)

@meganesu
Copy link
Contributor

Hi @tobyglei, thanks for your patience! As of right now, we're only moving our most frequently visited docs into the /docs/how-to/... folder structure.

We can merge the changes to update the links in the current deploy guide, but you'll need to move the doc back into the /docs/docs directory first. Thanks for your contribution!

@tobyglei
Copy link
Contributor Author

Hi @tobyglei, thanks for your patience! As of right now, we're only moving our most frequently visited docs into the /docs/how-to/... folder structure.

Just you to be aware of there are a lot of interests in deploying Gatsby in China but there is lack of supports and docs out there. I'm trying to fill in the gap here. As for the current Gatsby's docs structure it's hard to find related docs on getting Gatsby deploy in China, so that was why I moved it to the /docs/how-to/.

FYI: Why launching websites in general isn't easy in China

We can merge the changes to update the links in the current deploy guide, but you'll need to move the doc back into the /docs/docs directory first. Thanks for your contribution!

Will do.

@LekoArts LekoArts changed the title chore(docs): Move "deployting-to-21yunbox.md" to the "how-to" folder chore(docs): Update 21yunbox guide May 6, 2021
@LekoArts LekoArts merged commit 9abd34e into gatsbyjs:master May 6, 2021
axe312ger pushed a commit that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants