Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query-runner] Prevent empty error message for GraphQL errors #2891

Merged
merged 2 commits into from
Nov 13, 2017

Conversation

sebastienfi
Copy link
Contributor

A raw solution to prevent GraphQL queries from having any error messages. Better an ugly error message than no error message, isn't it?
Probably a more suitable solution would be to modify this function so that it accepts more input formatting. I don't have time to do that this month, I hope someone else will have time to focus on it.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 11, 2017

Deploy preview ready!

Built with commit 854a961

https://deploy-preview-2891--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 11, 2017

Deploy preview ready!

Built with commit 854a961

https://deploy-preview-2891--using-drupal.netlify.com

@KyleAMathews KyleAMathews merged commit 64b297e into master Nov 13, 2017
@KyleAMathews KyleAMathews deleted the query-reunner-gql-errors branch November 13, 2017 17:50
@KyleAMathews
Copy link
Contributor

Thanks! Yeah, this is a good idea — if we don't know how to neatly display an error — just spew out an unfiltered version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants