Convert var to let & Convert Non-strict to strict equality checking #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the more obscure equality algorithm used when using == / != and rely on the strict equality checking algorithm employed by === / !===
|
Deploy preview ready! Built with commit 1a42593 |
|
Deploy preview ready! Built with commit 1a42593 |
| @@ -48,6 +48,6 @@ export default class SessionStorage { | |||
| getStateKey(location, key) { | |||
| const locationKey = location.key | |||
| const stateKeyBase = `${STATE_KEY_PREFIX}${locationKey}` | |||
| return key == null ? stateKeyBase : `${stateKeyBase}|${key}` | |||
| return key === null ? stateKeyBase : `${stateKeyBase}|${key}` | |||
There was a problem hiding this comment.
This changes the logic as it's not now checking for undefined https://stackoverflow.com/a/5515385/182702 If you want to use the strict equality check, could you also add a check for undefined?
There was a problem hiding this comment.
Sure, will do, thanks @KyleAMathews
|
Thanks! |
|
No problem, glad to help. |
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.