-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-wordpress): schema customization errors #30358
Conversation
…revent gql errors with interfaces
…s are gatsby node types
...-source-wordpress/src/steps/create-schema-customization/transform-fields/default-resolver.js
Show resolved
Hide resolved
packages/gatsby-source-wordpress/src/steps/create-schema-customization/build-types.js
Outdated
Show resolved
Hide resolved
packages/gatsby-source-wordpress/src/steps/create-schema-customization/index.js
Outdated
Show resolved
Hide resolved
…tomization-errors
Seems like the failing tests are unrelated to this PR |
Should this be a V2 hotfix? Or V3? V3 project is |
@vladar I've heard from some users that they haven't been able to move on from v2 yet because they've run into a lot of troubles. I did ask them to open issues so we can fix them but I know they're still on v2 for now. Do we have a support plan for v2? EDIT: I checked that the v3 specific change with prefixing the __typename field works on Gatsby v2 if that's why you're asking. The other schema customization issues were present in v2 as well. |
Yeah I was confused by the first item in the list:
So I assumed it was a fix for v3. Thanks for clarifying this 👍
Are there any related open issues about it? |
* use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744)
* use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744)
…30650) * use new reporter.panic signature with error code for schema customization * add the prefixed typename as a node property when creating nodes to prevent gql errors with interfaces * fix union types that have a field called "type" * prevent excluded types from throwing errors in connection fields * test node interface resolution * test that interfaces that are mixed node and non-node resolve * prefix the __typename field in the default resolver for Gatsby v3 * an interface type is only a gatsby node type if all implementing types are gatsby node types * exclude Commenter.databaseId in int tests to get around WPGQL bug * only return null if there's no gatsby node AND no resolved field data (cherry picked from commit 5c9b744) Co-authored-by: Tyler Barnes <[email protected]>
This PR fixes:
Abstract type \"WpTermNode\" was resolve to a type \"Category\" that does not exist inside schema.
since the typename is actually WpCategory.