Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 #33120

Merged
merged 5 commits into from
Sep 10, 2021

Conversation

DanielSLew
Copy link
Contributor

Description

In order to unblock the gatsby-starter-shopify from being migrated to Gatsby v4 we needed to fix the gatsbyPath resolver. This resolver relies on extensions from the program, but this program wasn't getting fully set in the workers.

We also needed to use onPluginInit when compatible with the Gatsby version.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 9, 2021
@DanielSLew DanielSLew changed the title Fix gatsby plugin page creator v4 fix(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 Sep 9, 2021
@DanielSLew DanielSLew added gatsby 4 and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 9, 2021
@DanielSLew DanielSLew changed the title fix(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 feat(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 Sep 9, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark. I need to test it to make sure but looks good!

packages/gatsby/src/bootstrap/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielSLew DanielSLew merged commit 4837b72 into master Sep 10, 2021
@DanielSLew DanielSLew deleted the fix-gatsby-plugin-page-creator-v4 branch September 10, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants