Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gatsby] don't run service-workers outside of https or localhost #3502

Merged
merged 4 commits into from
Jan 12, 2018
Merged

[gatsby] don't run service-workers outside of https or localhost #3502

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
298b4cc
[gatsby] don't run service-workers outside of https or localhost
busticated Jan 12, 2018
1ba780e
add detail around running local changes to CONTRIBUTING.md
busticated Jan 12, 2018
28a85c6
Update CONTRIBUTING.md
KyleAMathews Jan 12, 2018
3946c0e
format
KyleAMathews Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ The usual contributing steps are:
build of all packages and then watch for changes to packages' source code and
compile these changes on-the-fly as you work.
* Install [gatsby-dev-cli](/packages/gatsby-dev-cli/) globally: `yarn global add gatsby-dev-cli`
* Run `yarn install` in each of the sites you're testing with.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run yarn install first, then gatsby-dev will copy over correctly all your source updates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* For each of your Gatsby test sites, run the `gatsby-dev` command there to copy
the built files from your cloned copy of Gatsby. It'll watch for your changes
to Gatsby packages and copy them into the site. For more detailed instructions
Expand Down
9 changes: 8 additions & 1 deletion packages/gatsby/cache-dir/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ apiRunnerAsync(`onClientEntry`).then(() => {
*
* Let's unregister the service workers in development, and tidy up a few errors.
*/
if (`serviceWorker` in navigator) {
if (supportsServiceWorkers(location, navigator)) {
navigator.serviceWorker.getRegistrations().then(registrations => {
for (let registration of registrations) {
registration.unregister()
Expand Down Expand Up @@ -69,3 +69,10 @@ apiRunnerAsync(`onClientEntry`).then(() => {
})
}
})

function supportsServiceWorkers(location, navigator){
if (location.hostname === `localhost` || location.protocol === `https:`){
return `serviceWorker` in navigator
}
return false
}