Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from express-graphql to graphql-http #37001

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Nov 9, 2022

Description

See graphql/express-graphql#816 + express-graphql doesn't have updated peer deps for graphql@16, causing quite a lot of problems when installing with npm (for whatever reason yarn seems to more resilient to things like that). This is attempt at 1:1 replacement preserving some customizations we had weith express-graphql ( showing stack traces per graphql error + showing some toggles as extensions)

Related Issues

[ch-58093]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 9, 2022
@pieh pieh added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 9, 2022
@pieh pieh marked this pull request as ready for review November 9, 2022 14:51
@pieh pieh merged commit 3a4d333 into master Nov 9, 2022
@pieh pieh deleted the drop-express-graphql branch November 9, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants