Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable source maps in production (v2) #3818

Closed
wants to merge 2 commits into from
Closed

Disable source maps in production (v2) #3818

wants to merge 2 commits into from

Conversation

tomazy
Copy link
Contributor

@tomazy tomazy commented Feb 2, 2018

Fixes #3817

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this!

// sure that your web server restricts access to them (e.g. with
// basic auth):
//
// exports.modifyWebpackConfig = ({ config, stage }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API for modifying webpack config has changed. Instead of directly mutating the webpack config, there's a new action named setWebpackConfig. If you grep the v2 branch, you'll find a number of usages for this + I think there's docs already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed.

@tomazy tomazy changed the title Disable source maps in production Disable source maps in production (v2) Feb 2, 2018
@KyleAMathews
Copy link
Contributor

Hmmmm... so I might have changed my mind about this. I agree with @jquense (#3817 (comment)) that they're more useful than not. Instead of disabling it by default — how about instead we a) investigate using relative paths, removing comments and otherwise making them more tidy by default and b) add a plugin to easily disable producing source maps by modifying the webpack config which also conveniently would speed up builds some.

This was referenced Sep 5, 2021
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants