Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to next.gatsbyjs.org #8134

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Small updates to next.gatsbyjs.org #8134

merged 4 commits into from
Sep 14, 2018

Conversation

m-allanson
Copy link
Contributor

@m-allanson m-allanson commented Sep 13, 2018

Resolves most of the items at #7378. Some design changes, needs review from @fk!

@fk I changed the diagram label text from white to gray, and darkened one line of text to fix the contrast warnings:

Before:
screen shot 2018-09-13 at 23 33 51

After:
screen shot 2018-09-13 at 23 33 34

I've also added font-display: swap to the fonts.

There's one outstanding issue related to a console error from the offline plugin, but I'm going to investigate further and create a separate PR for that.

@m-allanson m-allanson requested a review from fk September 13, 2018 22:37
Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m-allanson m-allanson merged commit be76c50 into master Sep 14, 2018
@m-allanson m-allanson deleted the site-tweaks branch September 14, 2018 07:26
@@ -24,6 +24,7 @@

@font-face {
font-family: "Futura PT";
font-display: swap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ~200ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants