Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Fix appearance of first-level sidebar nav items that link to a page and contain subitems #8170

Conversation

fk
Copy link
Contributor

@fk fk commented Sep 14, 2018

This PR aligns the appearance of top-level items that link to a page and contain subitems ("top-level split buttons") with the appearance of top-level items which do not link to a page themselves but only serve as a "header" to group and allow to expand/collapse its subitems.


If you take a look at the "Behind the Scenes" link in the sidebar, you'll notice that it's not set in "Futura PT", and upon further inspection that its text is all uppercase, while e.g. "Conceptual Guides" is uppercased via CSS:

image

👇 👇 👇

image

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Noticed that the font was off on that one too :-D

@KyleAMathews KyleAMathews merged commit 2df7889 into master Sep 14, 2018
@KyleAMathews KyleAMathews deleted the topics/www-sidebar-top-level-item-split-button-font-family branch September 14, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants