Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error 400 caused by continuation-token and start-after #676

Open
mervynzhang opened this issue Aug 9, 2024 · 0 comments
Open

error 400 caused by continuation-token and start-after #676

mervynzhang opened this issue Aug 9, 2024 · 0 comments

Comments

@mervynzhang
Copy link

Hi @gaul ,

delta-kernel-rs report 400 when list more than 1000 files because of this check:

if (continuationToken != null && startAfter != null) {
throw new S3Exception(S3ErrorCode.INVALID_ARGUMENT);
}

In some case, continuation-token and start-after would be both set, but it's not something really bad. I tried to submit a PR to delta-kernel-rs to avoid this error, delta-incubator/delta-kernel-rs#312.

It will be helpful if we can loose this check too. Is it Ok to just log a warning or just skip this check?

ObjectStore(
    Generic {
        store: "S3",
        source: ListRequest {
            source: Client {
                status: 400,
                body: Some(
                    "<?xml version='1.0' encoding='UTF-8'?><Error><Code>InvalidArgument</Code><Message>Bad Request</Message><RequestId>4442587FB7D0A2F9</RequestId></Error>",
                ),
            },
        },
    },
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant