Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh install fails without DBI and assertthat packages #12

Closed
ConorIA opened this issue Nov 22, 2016 · 3 comments
Closed

Fresh install fails without DBI and assertthat packages #12

ConorIA opened this issue Nov 22, 2016 · 3 comments
Assignees

Comments

@ConorIA
Copy link
Contributor

ConorIA commented Nov 22, 2016

Hi Gavin,

I just tried installing on a fresh lab computer (i.e. on a fresh library). The install fails complaining that DBI and assertthat are missing. I thought to send a PR, but wasn't sure whether these would be imports or dependencies, so I thought I'd ping you first.

Cheers

@gavinsimpson gavinsimpson added bug and removed bug labels Nov 22, 2016
@gavinsimpson
Copy link
Owner

It seems this is coming from our importing of the dplyr package. I need to check again, but with changes in tibble we may not need dplyr any longer. Either way, I don't think this is an issue with canadaHCD unless we are specifically using functionality from those packages; installing dplyr should have ensured that the stated packages were installed as those are dependencies of dplyr.

@gavinsimpson gavinsimpson self-assigned this Nov 22, 2016
@gavinsimpson
Copy link
Owner

gavinsimpson commented Nov 22, 2016

We can't remove the dependency on dplyr until equivalent dplyr::bind_rows() functionality is available in tibble but that may be some time off, see tidyverse/tibble#34.

@ConorIA
Copy link
Contributor Author

ConorIA commented Nov 27, 2016

I have just installed canadaHCD on a very minimal R implementation on Linux (via Docker - specifically https://github.com/ConorIA/dockerfiles/tree/master/alpine-r). There was no such issue. Not sure why I had trouble on Windows but not on Linux (I should mention that I have always used Linux before now, and never had any issue installing canadaHCD). At any rate, this doesn't seem to be canadaHCD's fault, so I will go ahead and close this issue.

@ConorIA ConorIA closed this as completed Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants