-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive in ABI checker #336
Comments
I got the same false-(?)positive again: This time it's on I'm testing it locally and it does look like the |
I'm now seeing a different false positive in gazebosim/gz-transport#216 with complaints about header files that were not modified at all:
The API check says two symbols were added and two removed:
The ABI check says 8 symbols were removed:
|
The ABI checker job is failing for gazebosim/gz-sim#416, complaining that the
ignition::gazebo::v3::components::BaseComponent::Serialize ( std::ostream& p1 ) const
symbol has been removed. I've reproduced the failure in multiple builds:This is strange because the pull request doesn't change remove the symbol; it doesn't even change any header files. I suspect that this is a false positive.
The text was updated successfully, but these errors were encountered: