You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a bad pattern, better handled with: IGN_<LIB>_VER N-1 -> IGN_<LIB>_VER ${ignition-<lib><N>_VERSION_MAJOR}
However, that means that the libraries have to be found BEFORE the variable is set. Using the script to fix this won't work because the script won't know how to reorder the lines.
Fix: Manually update the examples or any other instances to eliminate the pattern
where is an example of this? I often see this as set(IGN_PLUGIN_VER ${ignition-plugin1_VERSION_MAJOR}), which I think is better, since it should be more compatible with the autocompletes
I suppose it could be IGN_<LIB>_VER <any_digit> -> IGN_<LIB>_VER ${ignition-<lib>N_VERSION_MAJOR} instead? Though it'll remove affect any deliberate pins.
I suppose it could be IGN_<LIB>_VER <any_digit> -> IGN_<LIB>_VER ${ignition-<lib>N_VERSION_MAJOR} instead? Though it'll remove affect any deliberate pins.
Description
This issue tracks all the various edgecases I've encountered in the
ign
togz
migration, running the scripts in https://github.com/ignition-tooling/release-tools/tree/master/release-repo-scriptsScripts
bump_dependency.bash
ign-tools2 2.0.0
->ign-tools3 2.0.0
don't bump properly. (2.0.0
is expected to be bumped to3.0.0
)ign-tools2 VERSION 2.0.0
)IGN_<LIB>_VER N-1
->IGN_<LIB>_VER N
is not addressedIGN_<LIB>_VER N-1
->IGN_<LIB>_VER ${ignition-<lib><N>_VERSION_MAJOR
}-
?new_ignition_release_repos.bash
ign-tools
vsign-tools1
), the script can't pick it upgrep -r "ign-<lib>[^0-9]"
and inspect for anything missedThe text was updated successfully, but these errors were encountered: