From ee0061d9528da5b56ed3c22530c337216c1176fa Mon Sep 17 00:00:00 2001 From: Nate Koenig Date: Mon, 13 Mar 2023 21:09:34 -0700 Subject: [PATCH 1/3] Small cleanup fixes Signed-off-by: Nate Koenig --- include/ignition/launch/Plugin.hh | 3 +++ plugins/websocket_server/MessageDefinitions.hh.in | 2 ++ 2 files changed, 5 insertions(+) diff --git a/include/ignition/launch/Plugin.hh b/include/ignition/launch/Plugin.hh index a3b66e97..d452276a 100644 --- a/include/ignition/launch/Plugin.hh +++ b/include/ignition/launch/Plugin.hh @@ -30,6 +30,9 @@ namespace ignition /// \brief Base class for launch plugins. class Plugin { + // Default destructor + public virtual ~Plugin() {}; + /// \brief Load function that each launch plugin must implement. /// \param[in] _elem Pointer to the XML for this plugin. /// \return True to keep the plugin alive. Return false to have the diff --git a/plugins/websocket_server/MessageDefinitions.hh.in b/plugins/websocket_server/MessageDefinitions.hh.in index c6038d00..8bcc1457 100644 --- a/plugins/websocket_server/MessageDefinitions.hh.in +++ b/plugins/websocket_server/MessageDefinitions.hh.in @@ -17,6 +17,8 @@ #ifndef IGNITION_LAUNCH_WEBSOCKETSERVER_MESSAGEDEFINITIONS_HH_ #define IGNITION_LAUNCH_WEBSOCKETSERVER_MESSAGEDEFINITIONS_HH_ +#include + namespace ignition { namespace launch From 1a94534f8595eb3d75a8dc728105aacd82bda80f Mon Sep 17 00:00:00 2001 From: Nate Koenig Date: Fri, 17 Mar 2023 16:10:21 -0700 Subject: [PATCH 2/3] Missing colon Signed-off-by: Nate Koenig --- include/ignition/launch/Plugin.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/ignition/launch/Plugin.hh b/include/ignition/launch/Plugin.hh index d452276a..d12b4330 100644 --- a/include/ignition/launch/Plugin.hh +++ b/include/ignition/launch/Plugin.hh @@ -31,7 +31,7 @@ namespace ignition class Plugin { // Default destructor - public virtual ~Plugin() {}; + public: virtual ~Plugin() {}; /// \brief Load function that each launch plugin must implement. /// \param[in] _elem Pointer to the XML for this plugin. From 98860c948d8b1098f3a43b650aeaa64db0b7a0eb Mon Sep 17 00:00:00 2001 From: Steve Peters Date: Fri, 17 Mar 2023 17:49:25 -0700 Subject: [PATCH 3/3] Fix linting Signed-off-by: Steve Peters --- include/ignition/launch/Plugin.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/ignition/launch/Plugin.hh b/include/ignition/launch/Plugin.hh index d12b4330..1053916b 100644 --- a/include/ignition/launch/Plugin.hh +++ b/include/ignition/launch/Plugin.hh @@ -31,7 +31,7 @@ namespace ignition class Plugin { // Default destructor - public: virtual ~Plugin() {}; + public: virtual ~Plugin() {} /// \brief Load function that each launch plugin must implement. /// \param[in] _elem Pointer to the XML for this plugin.