Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for particle effects #249

Open
iche033 opened this issue Feb 16, 2021 · 0 comments
Open

Improve tests for particle effects #249

iche033 opened this issue Feb 16, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ogre2.x tests Broken or missing tests / testing infra

Comments

@iche033
Copy link
Contributor

iche033 commented Feb 16, 2021

Desired behavior

Better tests for particle effects system, like testing changing params like particle type, size, life time, velocity, duration, etc and verify image output

Alternatives considered

Testing those params in unit tests, which have already been done, but they do not verify the actual image output

Implementation suggestion

Add integration tests and verify generated image, e.g. set color and verify pixel rgb value, or change particle size and verify fewer pixels in the image are particles

Additional context

see comment: #241 (comment)

@iche033 iche033 added enhancement New feature or request tests Broken or missing tests / testing infra ogre2.x labels Feb 16, 2021
@iche033 iche033 mentioned this issue Feb 16, 2021
7 tasks
@chapulina chapulina added the help wanted Extra attention is needed label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ogre2.x tests Broken or missing tests / testing infra
Projects
None yet
Development

No branches or pull requests

2 participants