Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress new Jammy warnings #632

Merged
merged 1 commit into from
May 26, 2022
Merged

Suppress new Jammy warnings #632

merged 1 commit into from
May 26, 2022

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll [email protected]

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from iche033 as a code owner May 24, 2022 15:53
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 24, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I can see 100 Warnings more https://build.osrfoundation.org/job/ign_rendering-pr-win/2589/msbuild/

are going to address them in this PR ?

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #632 (211dd12) into main (5832255) will not change coverage.
The diff coverage is n/a.

❗ Current head 211dd12 differs from pull request most recent head 45caad0. Consider uploading reports for the commit 45caad0 to get more accurate results

@@           Coverage Diff           @@
##             main     #632   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits           12       12           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5832255...45caad0. Read the comment docs.

@mjcarroll
Copy link
Contributor Author

are going to address them in this PR ?

I can't see how they are related to this PR, so I will open an issue.

@mjcarroll mjcarroll merged commit 1172916 into main May 26, 2022
@mjcarroll mjcarroll deleted the jammy_warnings branch May 26, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants