Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to build FrameAttachedToGraph for static models with no links #282

Closed
scpeters opened this issue May 15, 2020 · 3 comments
Closed

Comments

@scpeters
Copy link
Member

In the initial version of the frame semantics proposal, all models were required to have at least one link, so that they could have a canonical link to which the implicit model frame (__model__) would be attached. This requirement was relaxed in the proposal in Bitbucket sdf_tutorials PR 45 (gazebosim/sdf_tutorials@dea8c40) so that static models would not be required to have a link with the rationale that its frames could be attached directly to the world. This was manifested in libsdformat with Bitbucket sdformat pull request 626 (4fa3f81?w=1), which stopped reporting errors for static models without a single link. Eliminating that error was the primary goal of that PR, and rather than also modify buildFrameAttachedToGraph to handle static models without links in that PR, it just skips building the FrameAttachedToGraph for all static models regardless of the number of links they have.

So, figure out how to build FrameAttachedToGraph for static models with no links.

@scpeters
Copy link
Member Author

@azeey
Copy link
Collaborator

azeey commented Dec 2, 2020

Can this be closed since #381 builds the FrameAttachedToGraph for static models?

@scpeters
Copy link
Member Author

scpeters commented Dec 2, 2020

sounds reasonable to me

@scpeters scpeters closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants