Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation warning: taking address of packed member #3

Open
glebm opened this issue Oct 23, 2021 · 3 comments · May be fixed by #9
Open

Compilation warning: taking address of packed member #3

glebm opened this issue Oct 23, 2021 · 3 comments · May be fixed by #9

Comments

@glebm
Copy link

glebm commented Oct 23, 2021

Not sure if benign or not:

_deps/libmpq-src/libmpq/mpq.c: In function ‘libmpq__block_open_offset’:
_deps/libmpq-src/libmpq/mpq.c:696:128: warning: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  696 |    if (libmpq__decrypt_key((uint8_t *)mpq_archive->mpq_file[file_number]->packed_offset, packed_size, mpq_archive->block_size, &mpq_archive->mpq_file[file_number]->seed) < 0) {
      |                                                                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@glebm glebm changed the title Compilation warning Compilation warning: taking address of packed member Oct 23, 2021
@glebm glebm linked a pull request Oct 25, 2021 that will close this issue
@ge0rg
Copy link
Owner

ge0rg commented Oct 26, 2021

Hey, it's great that you've taken up the lib after a decade! I've never been a maintainer myself, I just contributed a bit of code to it, and @mbroemme is the owner - and https://github.com/mbroemme/libmpq/ is the master repository. This fork is so old that github doesn't even show it as a fork ;)

If you want to contribute, I fear it's the best way to re-open all of the issues on the @mbroemme repository. Please let me know when you've done it and I'll close the issues and disable issues / PRs on this clone. Thanks and sorry for the additional work needed.

@glebm
Copy link
Author

glebm commented Oct 31, 2021

Ah, I see, thanks for replying. I've now reopened all the PRs in @mbroemme repository. Feel free to archive the repository with a big note pointing to mbroemme/libmpq.

@mbroemme
Copy link
Contributor

mbroemme commented Nov 2, 2021

@glebm Thanks for all the PRs, I will review them the next days in original repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants