Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Analyze Root Crate #190

Open
theduke opened this issue Feb 18, 2021 · 3 comments
Open

Only Analyze Root Crate #190

theduke opened this issue Feb 18, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@theduke
Copy link

theduke commented Feb 18, 2021

Currently dependencies are analyzed by default.

There is a --build-dependencies flag, which seems pointless since it is enabled automatically.

So there does not seem to be a way to only analyze the main crate and ignore all deps.

Is that correct?

@anderejd
Copy link
Contributor

Good point, thanks for filing the issue.

That flag is there for vestigial reasons, specifically me copy-pasting cargo-tree long ago as boiler plate for cargo-geiger. It can be removed.

We should add a flag for only scanning the main crate.

@anderejd anderejd added bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 19, 2021
@pinkforest pinkforest removed the good first issue Good for newcomers label Jan 6, 2022
@pinkforest
Copy link
Collaborator

Thanks for doing the PR 💜

I am working on a major overhaul with the CLI options as part of the cargo de-couple.

Aiming it for the 0.12.0 build - #241

As part of it we will be moving to clap 3 and the CLI options for cargo build are going to be mirrored as-is if --target was not used to skip build

Also regarding the analysis report

The idea now is to still support but separate reporting between different type of dependencies.

Thinking along the lines of -

cargo geiger build -- should do build deps

cargo geiger test -- should do test deps

cargo geiger run -- should do runtime deps

How would you feel about contributing to that?

🦄

@pinkforest
Copy link
Collaborator

pinkforest commented Jan 7, 2022

Also regarding depth of deps resolution

I would perhaps add

-dX || --depth X that translates to resolving X depth of deps immediate below crate where zero is no deps

And I would perhaps shorten

--no-deps vs --no-dependencies

Or just simply

-d0 Translates to --no-deps

Also I have cargo CLI options reform tracker here - #226

@pinkforest pinkforest removed the bug Something isn't working label Jan 7, 2022
@pinkforest pinkforest added this to the M-0.12.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants