Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multithreading in scanning phase #269

Closed
ilyatrefilov opened this issue Feb 21, 2022 · 2 comments · Fixed by #268
Closed

Multithreading in scanning phase #269

ilyatrefilov opened this issue Feb 21, 2022 · 2 comments · Fixed by #268
Assignees
@ilyatrefilov
Labels
enhancement New feature or request

Comments

@ilyatrefilov
Copy link
Contributor

ilyatrefilov commented Feb 21, 2022 •
edited
Loading

This issue is created to discuss/propose changes to current scanning phase in cargo-geiger.
Initially i made an implementation with rayon lib in this PR #268
@ilyatrefilov ilyatrefilov mentioned this issue Feb 21, 2022
Merged
@pinkforest pinkforest added the enhancement New feature or request label Feb 22, 2022
@pinkforest
Copy link
Collaborator

#268 on tokio-rs/tokio shaved ~6 seconds and I don't see the scanning progress popping up that I have to wait

Good stuff @ilyatrefilov 🚀

@pinkforest pinkforest mentioned this issue Feb 22, 2022
Closed
37 tasks
@pinkforest pinkforest linked a pull request Feb 22, 2022 that will close this issue
Introduce multithreading to scanning phase. #268
Merged
@pinkforest
Copy link
Collaborator

I don't think there is anything else to do for now so closing. Re-open if issue / feature identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilyatrefilov ilyatrefilov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce multithreading to scanning phase. ilyatrefilov/cargo-geiger
2 participants
@ilyatrefilov @pinkforest