Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use robot repair to create pull requests, rather than perform silent changes in release #27821

Closed
balhoff opened this issue May 2, 2024 · 1 comment · Fixed by #29167
Closed
Assignees

Comments

@balhoff
Copy link
Member

balhoff commented May 2, 2024

Currently robot repair is run during the ontology build:

$(ROBOT) merge --collapse-import-closure false -i go-edit-filtered-xrefs.ofn -i imports/go_taxon_constraints.owl -i imports/reactome_xrefs_import.owl -i imports/go-catalytic-activities-participants.owl remove --term 'IAO:0000116' --axioms annotation --signature true repair --annotation-property oboInOwl:hasDbXref annotate --annotation owl:versionInfo $(RELEASEDATE) -o $@

This moves xrefs from obsolete terms to their replacements. This is occasionally the source of confusion. It would be nice for repair to run in a GitHub action and create pull requests for proposed repairs.

@balhoff
Copy link
Member Author

balhoff commented Nov 6, 2024

Instead I will remove the repair command, since we prefer not to maintain xrefs on obsolete terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant