Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Share: incl marker from swisssearch result #3354

Closed
davidoesch opened this issue Jun 2, 2016 · 12 comments
Closed

Share: incl marker from swisssearch result #3354

davidoesch opened this issue Jun 2, 2016 · 12 comments

Comments

@davidoesch
Copy link
Contributor

ALL OS
ALL Browsers

step to reproduce

open application

Add "seftigenstrasse 264" in search
select address

map with marker is shown

Share map via share function

Result:
Address is not hghlighted

Expected result
Swissearch selected result is included " Use case: I search an address and share it as a result"

@loicgasser
Copy link
Contributor

loicgasser commented Jun 2, 2016

I agree it's a very common use case.

There are currently no easy way to achieve that. we could use the crosshair but the page will then be centered on the address.
To keep the position of the map and the marker at the correct location we would need two extra permalink parameters.

I would propose to add two extra permalink parameters.

Xsearch and Ysearch. this way we could even link a search result without an iframe.
@gjn @oterral thoughts?

I could take care of it.

@davidoesch
Copy link
Contributor Author

use the swisssearch with : limit=1 parameter?

@gjn
Copy link
Contributor

gjn commented Jun 2, 2016

limit: 1 will not help, was the selection of the user might not have been the first result.

We already have a way to put a marker on the map via the PL: 'crosshair=xxx'. Let's use it by having it in the PL as long as the search marker is on the map.

BUT: It's third priority - so let's do all the other stuff first.

@gjn
Copy link
Contributor

gjn commented Jun 2, 2016

Of course, crosshair will only be correct for as long as the map is not moved. When it's moved, then it would not longer be valid. (As @loicgasser noted in his comment)

@oterral
Copy link
Contributor

oterral commented Aug 23, 2016

Logically if we select Seftigenstrasse 264 3084 Wabern in search result we should add the swissearch parameter to permalink: ``swisssearch=Seftigenstrasse%20264%203084%20Wabern`

Then if you share the permalink with this swissearch you've the marker: https://mf-geoadmin3.dev.bgdi.ch?api_url=gjn_trans&swisssearch=Seftigenstrasse%20264%203084%20Wabern`

If the swisssearch is precise it should return only one result.

@davidoesch
Copy link
Contributor Author

I would not add swisssearch paramtere in the PL. simply it does not solve the issue the user has. we add location support in permalink (and alter on maybe address) in a first step with geoseo...but his is another project. so for now : let it as it is

@oterral
Copy link
Contributor

oterral commented Aug 23, 2016

we could also improve crosshair functionnality using crosshair=marker,x,y , shoudln't be hard.

@davidoesch
Copy link
Contributor Author

Backward compatibility?

@oterral
Copy link
Contributor

oterral commented Aug 23, 2016

if xor y are not present we use the default behavior

@davidoesch
Copy link
Contributor Author

OK in this case: a clear go

@davidoesch
Copy link
Contributor Author

ping @oterral , since #4002 is closed now

@boecklic
Copy link
Contributor

boecklic commented May 8, 2019

duplicate of #4666

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants