Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GH Actions #493

Closed
Nowosad opened this issue Apr 10, 2020 · 3 comments
Closed

Move to GH Actions #493

Nowosad opened this issue Apr 10, 2020 · 3 comments

Comments

@Nowosad
Copy link
Member

Nowosad commented Apr 10, 2020

I added GitHub Actions to our book. The code was based on our travis file, GitHub Actions of sf, and the ropensci-org/blog-guidance repo. You can learn more about it in the 5. How to deploy a preview of the book for pull requests part of https://ropensci.org/blog/2020/04/07/bookdown-learnings/.

This could be our first step for #476. I think the installation part works already - maybe we now need to update some settings related to Netlify, but I am not sure...

@Nowosad
Copy link
Member Author

Nowosad commented Apr 11, 2020

https://github.com/Robinlovelace/geocompr/runs/578699757?check_suite_focus=true Awesome!

@Robinlovelace
Copy link
Collaborator

The question now: what to do with Travis? I suggest we stop building on Travis and purge the travis set-up stuff. There may be benefits of keeping it but I guess the -s of maintenance time will outweigh the +s of having a backup CI system, GH Actions seems a solid foundation for #476 .

@Nowosad
Copy link
Member Author

Nowosad commented Apr 11, 2020

Completely agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants