Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch10: Internal GIS bridges chapter review #881

Closed
Nowosad opened this issue Oct 9, 2022 · 4 comments
Closed

Ch10: Internal GIS bridges chapter review #881

Nowosad opened this issue Oct 9, 2022 · 4 comments
Assignees

Comments

@Nowosad
Copy link
Member

Nowosad commented Oct 9, 2022

No description provided.

@Nowosad
Copy link
Member Author

Nowosad commented Oct 10, 2022

@jannes-m it would be good if you could also incorporate changes from #412.

@Nowosad Nowosad changed the title Internal GIS bridges chapter review Ch10: Internal GIS bridges chapter review Oct 10, 2022
@Nowosad Nowosad mentioned this issue Oct 10, 2022
@jannes-m
Copy link
Collaborator

jannes-m commented Oct 12, 2022

Hey @Nowosad,
first of all, thanks again for taking over the r-gis bridges chapter and the rewrite!
I have just started reviewing it, so this is still work-in-progress (see also #883). I will update this comment with further comments:

  • Shouldn't we display at least some of the output of qgis_show_help("native:union"). Otherwise it's quite hard for the reader to understand how we came up with the parameter names INPUT, OUTPUT and OVERLAY. And in the second example qgis_show_help("grass:v.clean") we should state explicitly that the output is not shown.
  • I think we should also mention that though you can use r spatial objects as inputs for qgisprocess, it is always computationally less demanding to use a file already living on disk since this way we avoid to load the object into R just to let qgisprocess save it back for the further processing in QGIS.
  • Though terra::terrain() is an interesting function, it is a bit out of scope here, when we are actually talking about integrations with 3rd party tools (like QGIS, etc.). Maybe we could skip the terra::terrain() code example and just say that you can also natively compute terrain charasterics in R but that there are many more such as the sagawetness index and geomorphons?

@Nowosad
Copy link
Member Author

Nowosad commented Oct 12, 2022

Hi @jannes-m -- yes to all. Can you do it?

@jannes-m
Copy link
Collaborator

Sure can do 😊

@Nowosad Nowosad closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants