Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FastScape restarting functionality into the ASPECT checkpointing framework #5989

Open
anne-glerum opened this issue Jul 25, 2024 · 0 comments

Comments

@anne-glerum
Copy link
Contributor

anne-glerum commented Jul 25, 2024

At the moment, the FastScape interface does it's own checkpointing and restarting. Its current implementation means that:

  1. The FastScape and ASPECT restart files could be out of sync if a crash occurs after calling FastScape and before writing an ASPECT checkpoint.
  2. fastscape.cc doesn't read in the restart files during its initialization, but during the first call to compute_velocity_constraints_on_boundary(). However, other plugins might want to query the interface for the value of checkpointed variables before that. For example, I'm setting compositional field boundary conditions based on FastScape info, and these constraints are computed before mesh deformation.
  3. Checkpointing FastScape interface variables only works if 'Steps between checkpoint' are used instead of 'Time between checkpoint'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant