Show warning on console when coordinate is string #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keichan34
requested changes
Jan 18, 2023
|
|
||
| if (geojson.features) { | ||
|
|
||
| geojson.features.forEach((feature) => { |
There was a problem hiding this comment.
for (const feature of geojson.features || []) { で直前のif文も省ける
基本的に for .. of 使いましょう
|
|
||
| if (feature.geometry.coordinates) { | ||
|
|
||
| const coordinates = feature.geometry.coordinates.flat(3); // flatten array for each geometry |
There was a problem hiding this comment.
(feature.geometry.coordinates || []).flat(3) でif文省く
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #295
Coordinates の 値が文字列の GeoJSON（例:
'coordinates': [ '139.77012634277344','35.68518697509636']）を、SimpleStyle クラスに渡した時に、コンソールに waning を表示するように修正しました。ワーニングのテキストを、
GeoJSON coordinate value must be numberにしているのですが、もしベターな表現があれば教えていただけるとありがたいです。（GeoJSON longitude and latitude should be number等のほうが良い、、？？）