Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search suggestions return values in other languages #1466

Closed
josegar74 opened this issue Feb 29, 2016 · 1 comment
Closed

Search suggestions return values in other languages #1466

josegar74 opened this issue Feb 29, 2016 · 1 comment
Labels
bug stale stale issue flagged for closure.

Comments

@josegar74
Copy link
Member

I create a metadata with a keyword in english, french (water, eau). The suggestions service is returning some values in other languages if specifying the q parameter:

  1. Using English and empty q parameter: http://localhost:8080/geonetwork/srv/eng/suggest?field=keyword&q=
    [""
    , 
    [
      "Boundaries" ,
      "World" ,
      "water"  ]   
    ] 

This looks ok.

  1. Using English and q parameter: http://localhost:8080/geonetwork/srv/eng/suggest?field=keyword&q=ea

    ["ea"
    , 
    [
      "Oceans" ,
      "eau"  ]
    ]

2 issues:

  • "eau" I guess should be returned only in French.
  • "Oceans" is returned with the query (q=ea), but not in the empty query (case 1), what seem not correct also.
@josegar74 josegar74 added this to the 3.0.4 milestone Feb 29, 2016
@josegar74 josegar74 modified the milestones: 3.0.4, 3.0.5 Mar 21, 2016
@Delawen Delawen added the bug label Jun 10, 2016
@josegar74
Copy link
Member Author

Seem related to this code:

https://github.com/geonetwork/core-geonetwork/blob/3.0.x/services/src/main/java/org/fao/geonet/services/main/SearchSuggestion.java#L220-L221

https://github.com/geonetwork/core-geonetwork/blob/3.0.x/core/src/main/java/org/fao/geonet/kernel/search/SearchManager.java#L1141

The code uses the language for analysis the text provided and the values retrieved from the index, but seem retrieving all the values for a field, without any language filter (not sure if possible).

@fxprunayre fxprunayre modified the milestones: 3.0.5, 3.0.6 Oct 3, 2016
@Delawen Delawen modified the milestones: 3.0.6, 3.2.3 Dec 15, 2017
@Delawen Delawen modified the milestones: 3.2.3, 3.4.3 Jun 27, 2018
@ticheler ticheler added the stale stale issue flagged for closure. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale stale issue flagged for closure.
Projects
None yet
Development

No branches or pull requests

4 participants