Delete ISO 19139 thumbnail in the metadata editor doesn't work in GeoNetwok 4.2.x

[josegar74]

Describe the bug

Trying to delete an ISO 19139 thumbnail in the metadata editor doesn't work in GeoNetwok 4.2.x, the resource is still displayed in the editor after trying to delete and in the XML, the gmd:graphicOverview element is not removed.

This file is different in 4.2.x:

https://github.com/geonetwork/core-geonetwork/blob/4.2.x/schemas/iso19139/src/main/plugin/iso19139/process/thumbnail-remove.xsl

Than in main:

https://github.com/geonetwork/core-geonetwork/blob/main/schemas/iso19139/src/main/plugin/iso19139/process/thumbnail-remove.xsl

The 4.2.x file is from this backport 1242d9c. It's unclear why it's different than in main branch

• Pull request to main: Passing key into update/remove process xslt for iso 19139 to fix issue with updating/deleting resources with same url #7431
• Backport pull request to 4.2.x: [Backport 4.2.x] Passing key into update/remove process xslt for iso 19139 to fix issue with updating/deleting resources with same url #7740

To Reproduce
Steps to reproduce the behavior:

1. Creaate an ISO19139 metadata
2. Link to an online resource and select Add a thumbnail
3. Upload an image file
4. In the metadata editor, delete the resource --> the editor is refreshed, but the resource is still there.

Expected behavior
The thumbnail is removed properly.

Additional context

@ianwallen I though the original pull request to main was intended for online resources, to be able to delete them properly if they have the same url. Is there any reason for this backport to use the same stuff for the thumbnails?

[ianwallen]

@josegar74

The intent was to also apply the logic to overviews as well as it is still possible to link multiple overviews with the same url. And if this were to happen and someone want to remove one then it should remove the correct one.

i.e.
Thumbnail 1
Thumbnail 2
Thumbnail 1

If the user click on delete for the last one then the last one should be removed and not the first one.

It seems like something went wrong on this change and the changes were not applied correctly on the main branch.
And they were not tested correctly on the 4.2.x branch.

Apologize for this error - let me apply a working fix to the main branch and we can backport the same changes 4.2.x and also HNAP

[josegar74]

Thanks @ianwallen