Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use conventional-pr-title for PR title validation #227

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Jun 20, 2022

How to

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • IE11 tested.
  • The title is formatted as a conventional-commit message.
  • The title contains WIP: if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

IMPORTANT: Squash commits before or on merge to prevent every small commit being written into the change log. The Pull Request title will be written as message for the new commit containing the squashed commits and there fore needs to be in conventional-commit format

@netlify
Copy link

netlify bot commented Jun 20, 2022

Deploy Preview for openlayers-editor ready!

Name Link
🔨 Latest commit 78bd1b5
🔍 Latest deploy log https://app.netlify.com/sites/openlayers-editor/deploys/62b09e2371da0b0008618d16
😎 Deploy Preview https://deploy-preview-227--openlayers-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danji90 danji90 merged commit 607e5ec into master Jun 20, 2022
@oterral oterral deleted the daniel/conventionalCommits branch April 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant